Add Cargo feature query_encoding_2 to use encoding_rs crate
#446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable feature to use encoding_rs implementation for EncodingOverride includes Cow optimizations by @hsivonen.
hides upstream types from downstream consumers. also deprecate `query_encoding` feature since it exposes upstream types.
due to EncodingOverride trait
|
☔ The latest upstream changes (presumably #453) made this pull request unmergeable. Please resolve the merge conflicts. |
42 tasks
|
The crate doesn't depending on any encoding-related crate anymore, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempt is substantially different than the previous approach in #445, so opening a separate PR.
Converts
EncodingOverrideto a trait, but does not go so far as to export the trait to downstream consumers. Instead, the exported API now takes a&[u8]encoding label where it used to takeencoding::EncodingRef. The old methods are still present, but deprecated.Fixes #444
This change is